Issue 6744062: Remove two params from GrGLProgramStage::setData that are no longer necessary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6744062: Remove two params from GrGLProgramStage::setData that are no longer necessary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bsalomon

Modified:
11 years, 11 months ago

Reviewers:
Stephen White

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove two params from GrGLProgramStage::setData that are no longer necessary. R=senorblanco@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=6031

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -79 lines)			Patch
M	src/effects/SkColorMatrixFilter.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramStage.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramStage.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Stephen White

11 years, 11 months ago (2012-10-22 17:16:22 UTC) #2

On 2012/10/22 17:13:29, bsalomon wrote:
> Lots o' files, but should be an easy review :)

LGTM

w00t!

Expand All Messages | Collapse All Messages