Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 6744061: Automatically handle converting gl_FragCoord to Skia's y-down device coords. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by bsalomon
Modified:
12 years ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Automatically handle converting gl_FragCoord to Skia's y-down device coords. NOTE: THIS WILL LIKELY REQUIRE GM REBASELINING. R=robertphillips@google.com,senorblanco@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=6030

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Automatically handle converting gl_FragCoord to Skia's y-down device coords. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -78 lines) Patch
M src/effects/SkLightingImageFilter.cpp View 1 10 chunks +13 lines, -20 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 2 chunks +3 lines, -12 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 4 chunks +44 lines, -35 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 5 chunks +16 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 3 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 5
bsalomon
12 years ago (2012-10-22 16:41:26 UTC) #1
bsalomon
On 2012/10/22 16:41:26, bsalomon wrote: I forgot to mention that I will remove the GrRenderTarget ...
12 years ago (2012-10-22 16:43:35 UTC) #2
Stephen White
Cool stuff. LGTM.
12 years ago (2012-10-22 16:45:23 UTC) #3
robertphillips
LGTM
12 years ago (2012-10-22 16:50:02 UTC) #4
bsalomon
12 years ago (2012-10-22 17:39:42 UTC) #5
Automatically handle converting gl_FragCoord to Skia's y-down device coords.

NOTE: THIS WILL LIKELY REQUIRE GM REBASELINING.

R=robertphillips@google.com,senorblanco@chromium.org
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b