Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 6741064: Combine the emit functions in GrGLProgramStage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bsalomon
Modified:
12 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Combine the emit functions in GrGLProgramStage. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6057

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -76 lines) Patch
M src/effects/SkBlendImageFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.h View 1 3 chunks +62 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2
bsalomon
12 years, 1 month ago (2012-10-23 17:03:43 UTC) #1
robertphillips
12 years, 1 month ago (2012-10-23 17:30:21 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b