Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7329)

Issue 6741063: Use Bullet for convex hull (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by nicholasbishop
Modified:
11 years, 6 months ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Github: https://github.com/nicholasbishop/blender/commits/convex-hull-bullet Commit messages =============== Bullet convex hull: add access to the original indices for vertices =============== Bullet: add convex hull computer to C API =============== Partially replace convex hull implementation with Bullet implementation * Bullet's convex hull implementation is significantly more robust than the one I implemented, as well as being faster. * This fixes bug [#32864] Convex Hull fails in some cases. That bug, and others like it, relate to the poor handling of co-planar surfaces in the input. Pretty much any model that is simple-subdivided a few times gave very bad results before, Bullet's implementation handles this much better. * In order to ensure a smooth transition, the Bullet output is translated into the existing HullTriangle hash structure. This makes it easy to ensure that the existing slot output stays the same; the interactions between the slots are somewhat complicated, detangling is a TODO.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -309 lines) Patch
extern/bullet2/src/Bullet-C-Api.h View 1 chunk +10 lines, -0 lines 0 comments Download
extern/bullet2/src/BulletDynamics/Dynamics/Bullet-C-API.cpp View 2 chunks +58 lines, -1 line 0 comments Download
extern/bullet2/src/LinearMath/btConvexHullComputer.h View 1 chunk +1 line, -0 lines 0 comments Download
extern/bullet2/src/LinearMath/btConvexHullComputer.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/bmesh/CMakeLists.txt View 2 chunks +5 lines, -0 lines 0 comments Download
source/blender/bmesh/intern/bmesh_opdefines.c View 3 chunks +4 lines, -0 lines 0 comments Download
source/blender/bmesh/operators/bmo_hull.c View 9 chunks +134 lines, -308 lines 0 comments Download
source/blender/editors/mesh/CMakeLists.txt View 1 chunk +4 lines, -0 lines 1 comment Download
source/blender/editors/mesh/editmesh_tools.c View 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/editors/mesh/mesh_ops.c View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nicholasbishop
11 years, 6 months ago (2012-10-23 05:08:16 UTC) #1
brechtvl
Looks ok to me, also works well in some tests. If scons files are updated ...
11 years, 6 months ago (2012-10-23 18:33:23 UTC) #2
nicholasbishop
11 years, 6 months ago (2012-10-23 23:56:14 UTC) #3
Thanks for reviewing, committed as r51557 and r51558 with the scons fixes.

On 2012/10/23 18:33:23, brechtvl wrote:
> Looks ok to me, also works well in some tests. If scons files are updated too
> this LGTM.
> 
>
https://codereview.appspot.com/6741063/diff/1/source/blender/editors/mesh/CMa...
> File source/blender/editors/mesh/CMakeLists.txt (right):
> 
>
https://codereview.appspot.com/6741063/diff/1/source/blender/editors/mesh/CMa...
> source/blender/editors/mesh/CMakeLists.txt:77: add_definitions(-DUSE_BULLET)
> The convention is to use -DWITH_BULLET, although it looks like this is already
> inconsistent elsewhere.
> 
> More importantly though, this should be add to SConscript too in both
> editors/mesh/ and bmesh/.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b