Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(766)

Issue 6740045: add a "most" target, and make it the default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by epoger
Modified:
12 years, 1 month ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

add a "most" target, and make it the default split out of https://codereview.appspot.com/6651064/ ('gyp: generate "everything" and "most" targets instead of "all"') tests: "make most" now works, "make" now calls "make most" Committed: https://code.google.com/p/skia/source/detail?r=5999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -10 lines) Patch
M Makefile View 2 chunks +2 lines, -1 line 0 comments Download
A gyp/most.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
M gyp_skia View 1 chunk +3 lines, -0 lines 0 comments Download
M make.py View 4 chunks +15 lines, -9 lines 0 comments Download
M skia.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
epoger
12 years, 1 month ago (2012-10-18 16:04:54 UTC) #1
EricB
12 years, 1 month ago (2012-10-18 16:09:04 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b