Only use data when there is a dataWrapper.

Fixes #208

[jcgregorio_google, 2012-10-23 16:31:30]

LGTM

https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py
File tests/test_json_model.py (right):

https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py#newcod...
tests/test_json_model.py:260: def test_data_wrapper_deserialize_nondict(self):
Technically this test isn't needed because the response is guaranteed to be a
dictionary.

[Ali Afshar, 2012-10-23 16:39:28]

https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py
File tests/test_json_model.py (right):

https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py#newcod...
tests/test_json_model.py:260: def test_data_wrapper_deserialize_nondict(self):
On 2012/10/23 16:31:30, jcgregorio_google wrote:
> Technically this test isn't needed because the response is guaranteed to be a
> dictionary.

Shall I remove it?

[jcgregorio_google, 2012-10-23 16:40:35]

Yeah, go ahead and remove it to avoid confusion.

On 2012/10/23 16:39:28, Ali Afshar wrote:
> https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py
> File tests/test_json_model.py (right):
> 
>
https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py#newcod...
> tests/test_json_model.py:260: def test_data_wrapper_deserialize_nondict(self):
> On 2012/10/23 16:31:30, jcgregorio_google wrote:
> > Technically this test isn't needed because the response is guaranteed to be
a
> > dictionary.
> 
> Shall I remove it?

[Ali Afshar, 2012-10-23 16:42:58]

Done

The code in model.py does check that the body is a dict, should that be removed?

On 2012/10/23 16:40:35, jcgregorio_google wrote:
> Yeah, go ahead and remove it to avoid confusion.
> 
> On 2012/10/23 16:39:28, Ali Afshar wrote:
> > https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py
> > File tests/test_json_model.py (right):
> > 
> >
>
https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py#newcod...
> > tests/test_json_model.py:260: def
test_data_wrapper_deserialize_nondict(self):
> > On 2012/10/23 16:31:30, jcgregorio_google wrote:
> > > Technically this test isn't needed because the response is guaranteed to
be
> a
> > > dictionary.
> > 
> > Shall I remove it?

[jcgregorio_google, 2012-10-23 16:58:43]

On 2012/10/23 16:42:58, Ali Afshar wrote:
> Done
> 
> The code in model.py does check that the body is a dict, should that be
removed?

No, I like being defensive, I was just worried that a test that showed a
non-dict being returned would mislead someone reading the tests.

> 
> On 2012/10/23 16:40:35, jcgregorio_google wrote:
> > Yeah, go ahead and remove it to avoid confusion.
> > 
> > On 2012/10/23 16:39:28, Ali Afshar wrote:
> > > https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py
> > > File tests/test_json_model.py (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py#newcod...
> > > tests/test_json_model.py:260: def
> test_data_wrapper_deserialize_nondict(self):
> > > On 2012/10/23 16:31:30, jcgregorio_google wrote:
> > > > Technically this test isn't needed because the response is guaranteed to
> be
> > a
> > > > dictionary.
> > > 
> > > Shall I remove it?

[Ali Afshar, 2012-10-23 18:15:34]

Pushed in
http://code.google.com/p/google-api-python-client/source/detail?r=5032f9751ca...

On 2012/10/23 16:58:43, jcgregorio_google wrote:
> On 2012/10/23 16:42:58, Ali Afshar wrote:
> > Done
> > 
> > The code in model.py does check that the body is a dict, should that be
> removed?
> 
> No, I like being defensive, I was just worried that a test that showed a
> non-dict being returned would mislead someone reading the tests.
> 
> > 
> > On 2012/10/23 16:40:35, jcgregorio_google wrote:
> > > Yeah, go ahead and remove it to avoid confusion.
> > > 
> > > On 2012/10/23 16:39:28, Ali Afshar wrote:
> > > > https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py
> > > > File tests/test_json_model.py (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.appspot.com/6737065/diff/1/tests/test_json_model.py#newcod...
> > > > tests/test_json_model.py:260: def
> > test_data_wrapper_deserialize_nondict(self):
> > > > On 2012/10/23 16:31:30, jcgregorio_google wrote:
> > > > > Technically this test isn't needed because the response is guaranteed
to
> > be
> > > a
> > > > > dictionary.
> > > > 
> > > > Shall I remove it?