Issue 6737059: Removed degenerate quads from zero radius Chrome-style round rects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6737059: Removed degenerate quads from zero radius Chrome-style round rects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by robertphillips

Modified:
12 years, 1 month ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

BEFORE zeroradroundrect 8888: cmsecs = 32.14 565: cmsecs = 31.04 GPU: cmsecs = 26.36 gmsecs = 24.57 NULLGPU: cmsecs = 20.28 gmsecs = 0.09 AFTER zeroradroundrect 8888: cmsecs = 21.53 565: cmsecs = 20.59 GPU: cmsecs = 18.10 gmsecs = 17.17 NULLGPU: cmsecs = 13.26 gmsecs = 0.08

Patch Set 1 #

Patch Set 2 : Updated comment #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -14 lines)			Patch
M	bench/PathBench.cpp	View		5 chunks	+28 lines, -10 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/PathTest.cpp	View		4 chunks	+37 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

robertphillips

12 years, 1 month ago (2012-10-23 16:57:32 UTC) #2

Received verbal lgtm from reed@

committed as r6053

Expand All Messages | Collapse All Messages