Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(880)

Issue 6736043: Add version property in IBusEngineDesc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by fujiwara
Modified:
1 year, 6 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Add version property in IBusEngineDesc.


BUG=http://code.google.com/p/ibus/issues/detail?id=1524
TEST=Manually

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated with message #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M ibus/enginedesc.py View 1 6 chunks +11 lines, -1 line 0 comments Download
M src/ibusenginedesc.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/ibusenginedesc.c View 1 14 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4
fujiwara
1 year, 6 months ago #1
Peng
https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py File ibus/enginedesc.py (right): https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode151 ibus/enginedesc.py:151: if len(struct) < 3: I think it is not ...
1 year, 6 months ago #2
fujiwara
On 2012/10/18 16:54:53, Peng wrote: > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py > File ibus/enginedesc.py (right): > > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode151 > ...
1 year, 6 months ago #3
Peng
1 year, 6 months ago #4
lgtm

On 2012/10/19 01:46:56, fujiwara wrote:
> On 2012/10/18 16:54:53, Peng wrote:
> > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py
> > File ibus/enginedesc.py (right):
> > 
> > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode151
> > ibus/enginedesc.py:151: if len(struct) < 3:
> > I think it is not necessary to change it to from 2 to 3.
> > 
> > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode154
> > ibus/enginedesc.py:154: self.__layout_option    = struct.pop(0)
> > It is better to an another test here.
> > like:
> > if len(struct) < 1:
> >    return
> > 
> > https://codereview.appspot.com/6736043/diff/1/src/ibusenginedesc.c
> > File src/ibusenginedesc.c (right):
> > 
> >
https://codereview.appspot.com/6736043/diff/1/src/ibusenginedesc.c#newcode545
> > src/ibusenginedesc.c:545: if (g_variant_n_children (variant) < retval + 3)
> > Same.
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5