Issue 6736043: Add version property in IBusEngineDesc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6736043: Add version property in IBusEngineDesc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by fujiwara

Modified:
11 years, 6 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Add version property in IBusEngineDesc. BUG=http://code.google.com/p/ibus/issues/detail?id=1524 TEST=Manually

Patch Set 2 : Updated with message #2 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -1 line)			Patch
M	ibus/enginedesc.py	View	1	6 chunks	+11 lines, -1 line	0 comments	Download
M	src/ibusenginedesc.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/ibusenginedesc.c	View	1	14 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py File ibus/enginedesc.py (right): https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode151 ibus/enginedesc.py:151: if len(struct) < 3: I think it is not ...

11 years, 6 months ago (2012-10-18 16:54:53 UTC) #2

fujiwara

On 2012/10/18 16:54:53, Peng wrote: > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py > File ibus/enginedesc.py (right): > > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode151 > ...

11 years, 6 months ago (2012-10-19 01:46:56 UTC) #3

Peng

11 years, 6 months ago (2012-10-19 15:25:25 UTC) #4

lgtm

On 2012/10/19 01:46:56, fujiwara wrote:
> On 2012/10/18 16:54:53, Peng wrote:
> > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py
> > File ibus/enginedesc.py (right):
> > 
> > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode151
> > ibus/enginedesc.py:151: if len(struct) < 3:
> > I think it is not necessary to change it to from 2 to 3.
> > 
> > https://codereview.appspot.com/6736043/diff/1/ibus/enginedesc.py#newcode154
> > ibus/enginedesc.py:154: self.__layout_option    = struct.pop(0)
> > It is better to an another test here.
> > like:
> > if len(struct) < 1:
> >    return
> > 
> > https://codereview.appspot.com/6736043/diff/1/src/ibusenginedesc.c
> > File src/ibusenginedesc.c (right):
> > 
> >
https://codereview.appspot.com/6736043/diff/1/src/ibusenginedesc.c#newcode545
> > src/ibusenginedesc.c:545: if (g_variant_n_children (variant) < retval + 3)
> > Same.
> 
> Done.

Expand All Messages | Collapse All Messages