Issue 6733065: Enable Android executables (like skia_launcher) to redirect SkDebugf output to stdout as well as th…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6733065: Enable Android executables (like skia_launcher) to redirect SkDebugf output to stdout as well as th… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by DerekS

Modified:
11 years, 8 months ago

Reviewers:
EricB, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Enable Android executables (like skia_launcher) to redirect SkDebugf output to stdout as well as the system logs. Committed: https://code.google.com/p/skia/source/detail?r=6059

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated name #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	src/ports/SkDebug_android.cpp	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

EricB

11 years, 8 months ago (2012-10-23 17:06:13 UTC) #2

https://codereview.appspot.com/6733065/diff/1/src/ports/SkDebug_android.cpp
File src/ports/SkDebug_android.cpp (right):

https://codereview.appspot.com/6733065/diff/1/src/ports/SkDebug_android.cpp#n...
src/ports/SkDebug_android.cpp:17: static bool gPrintToConsole = false;
Maybe gAndroidSkDebugToConsole?

Expand All Messages | Collapse All Messages