Issue 6727052: Make debugger print more information for paths

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6727052: Make debugger print more information for paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by robertphillips

Modified:
11 years, 11 months ago

Reviewers:
DerekS, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Seeing the verbs & convexity values is useful.

Patch Set 2 : Altered to use SkPath::Iter #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -7 lines)			Patch
	M	debugger/SkObjectParser.cpp	View	1	1 chunk	+41 lines, -7 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

DerekS

https://codereview.appspot.com/6727052/diff/1/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.appspot.com/6727052/diff/1/src/core/SkPath.cpp#newcode517 src/core/SkPath.cpp:517: return fPathRef->verbs()[~index]; I'm not familiar with this code, but ...

11 years, 11 months ago (2012-10-17 19:12:28 UTC) #3

DerekS

this looks much cleaner, but since I'm not an expert on the path code I'm ...

11 years, 11 months ago (2012-10-18 12:36:13 UTC) #6

committed as r5993

Expand All Messages | Collapse All Messages