Allow users to disable git's copy detection

Allow users to disable git's copy detection

Depended on by: https://chromiumcodereview.appspot.com/11195012/

Re: http://code.google.com/p/chromium/issues/detail?id=155511

[M-A, 2012-10-16 22:36:22]

https://codereview.appspot.com/6726050/diff/1/upload.py
File upload.py (right):

https://codereview.appspot.com/6726050/diff/1/upload.py#newcode595
upload.py:595: group.add_option("--git_find_copies", action="store_true",
upload.py doesn't have --foo --no-foo options so I don't think --git_find_copies
is useful here. Just keep --git_no_find_copies.

https://codereview.appspot.com/6726050/diff/1/upload.py#newcode599
upload.py:599: dest="git_find_copies",
default=True, here will work just fine if you remove --git_find_copies.

https://codereview.appspot.com/6726050/diff/1/upload.py#newcode1347
upload.py:1347: similarity_options = ["-M", "-M"]
I'd still use self.options.git_similarity here.

[iannucci, 2012-10-16 23:07:51]

Fixed all

[M-A, 2012-11-13 15:19:38]

On 2012/10/16 23:07:51, iannucci wrote:
> Fixed all

But you never uploaded a new patchset.

[iannucci, 2012-11-13 19:15:14]

On 2012/11/13 15:19:38, M-A wrote:
> On 2012/10/16 23:07:51, iannucci wrote:
> > Fixed all
> 
> But you never uploaded a new patchset.

Hmm... curious...

I'll fix

[iannucci, 2012-11-13 19:25:28]

Oh odd... I did upload the patches... I must have done something wrong
though, because they showed up here (https://codereview.appspot.com/6725051/)
and here (https://codereview.appspot.com/6725054/). Really not sure what
happened there (or why I didn't notice it). It almost seems like the
issuenumber wasn't recorded in my local repo.

https://codereview.appspot.com/6725054/ is the latest one (I just added you
as reviewer and updated the message).



On Tue, Nov 13, 2012 at 11:15 AM, <iannucci@chromium.org> wrote:

> On 2012/11/13 15:19:38, M-A wrote:
>
>> On 2012/10/16 23:07:51, iannucci wrote:
>> > Fixed all
>>
>
>  But you never uploaded a new patchset.
>>
>
> Hmm... curious...
>
> I'll fix
>
>
https://codereview.appspot.**com/6726050/<https://codereview.appspot.com/6726...
>

[iannucci, 2012-11-13 19:49:47]

PTAL

[M-A, 2012-11-13 19:54:26]

On 2012/11/13 19:49:47, iannucci wrote:
> PTAL

Committed. You can close it.

[M-A, 2012-11-13 19:54:32]

and lgtm