Issue 6721047: Separate out the texture matrix from the coord-system change matrix in GrSamplerState.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6721047: Separate out the texture matrix from the coord-system change matrix in GrSamplerState. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Separate out the texture matrix from the coord-system change matrix in GrSamplerState. This is a step towards moving texture matrix to GrCustomStage. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5973

Patch Set 1 #

Total comments: 4

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -104 lines)			Patch
M	include/gpu/GrContext.h	View	4 chunks	+11 lines, -5 lines	0 comments	Download
M	include/gpu/GrPaint.h	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	include/gpu/GrSamplerState.h	View	1 chunk	+81 lines, -34 lines	2 comments	Download
M	src/gpu/GrDefaultPathRenderer.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	4 chunks	+18 lines, -18 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View	4 chunks	+6 lines, -6 lines	2 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	4 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

This is a step towards moving the texture matrix out of GrSamplerState and into GrCustomStage.

12 years, 2 months ago (2012-10-16 20:45:37 UTC) #1

robertphillips

LGTM + 1 typo fix & a question https://codereview.appspot.com/6721047/diff/1/include/gpu/GrSamplerState.h File include/gpu/GrSamplerState.h (right): https://codereview.appspot.com/6721047/diff/1/include/gpu/GrSamplerState.h#newcode80 include/gpu/GrSamplerState.h:80: * ...

12 years, 2 months ago (2012-10-16 21:30:16 UTC) #2

bsalomon

12 years, 2 months ago (2012-10-17 12:53:56 UTC) #3

https://codereview.appspot.com/6721047/diff/1/include/gpu/GrSamplerState.h
File include/gpu/GrSamplerState.h (right):

https://codereview.appspot.com/6721047/diff/1/include/gpu/GrSamplerState.h#ne...
include/gpu/GrSamplerState.h:80: * preConcatCoordChange calls since the custom
stage was installed. It is used to
On 2012/10/16 21:30:16, robertphillips wrote:
> to when -> when

Done.

https://codereview.appspot.com/6721047/diff/1/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.appspot.com/6721047/diff/1/src/gpu/GrDrawState.cpp#newcode56
src/gpu/GrDrawState.cpp:56: if (fRestoreMask & (1 << s)) {
On 2012/10/16 21:30:16, robertphillips wrote:
> Can setMatrixDeprecated go away now?

Yup, it was removed in GrSamplerState.h.

Expand All Messages | Collapse All Messages