Issue 6718053: Add new bench to exercise SkPath::arcTo (arbroundrect)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6718053: Add new bench to exercise SkPath::arcTo (arbroundrect) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by robertphillips

Modified:
12 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This new test will also test the convexity of the arcTo results (once the next CL is delivered).

Patch Set 2 : Fixed parameter naming #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -0 lines)			Patch
	M	bench/PathBench.cpp	View	1	2 chunks	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM w/ a nit. https://codereview.appspot.com/6718053/diff/1/bench/PathBench.cpp File bench/PathBench.cpp (right): https://codereview.appspot.com/6718053/diff/1/bench/PathBench.cpp#newcode722 bench/PathBench.cpp:722: static void make_arb_round_rect(SkPath* path, const ...

12 years, 2 months ago (2012-10-17 15:19:14 UTC) #2

robertphillips

12 years, 2 months ago (2012-10-17 15:23:42 UTC) #3

committed as r5977

https://codereview.appspot.com/6718053/diff/1/bench/PathBench.cpp
File bench/PathBench.cpp (right):

https://codereview.appspot.com/6718053/diff/1/bench/PathBench.cpp#newcode722
bench/PathBench.cpp:722: static void make_arb_round_rect(SkPath* path, const
SkRect& r,
On 2012/10/17 15:19:14, bsalomon wrote:
> The fX/fY names make these vars look like members is Skia-land.

Done.

Expand All Messages | Collapse All Messages