Issue 6713055: Enable gm/aarectmodes with pdf config. Does not crash in mac (nor windows) according to comment. I …

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6713055: Enable gm/aarectmodes with pdf config. Does not crash in mac (nor windows) according to comment. I … (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by edisonn

Modified:
11 years, 9 months ago

Reviewers:
EricB, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Enable gm/aarectmodes with pdf config. Does not crash in mac (nor windows) according to comment. I am working to improve pdf, first step to have all gms export to pdf. Committed: https://code.google.com/p/skia/source/detail?r=6016

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	gm/aarectmodes.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

edisonn

Eric, on my local mac, aamodes does not crash, but it does not give correct ...

11 years, 9 months ago (2012-10-17 19:59:55 UTC) #1

EricB

If it doesn't crash then it shouldn't, but I don't have any way of knowing. ...

11 years, 9 months ago (2012-10-17 20:08:02 UTC) #2

bsalomon

11 years, 9 months ago (2012-10-19 12:56:35 UTC) #3

On 2012/10/17 20:08:02, EricB wrote:
> If it doesn't crash then it shouldn't, but I don't have any way of knowing. 
> Looks like this has been disabled since this test was created, for > 3000
> revisions.  I'm adding bsalomon@ who created the test.

This test was a variation of hairmodes.cpp which had the same flags. I think I
inadvertently left the onGetFlags implementation after my copy paste.

lgtm.

Expand All Messages | Collapse All Messages