Issue 6713051: Make table color filter use asNewCustomStage.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6713051: Make table color filter use asNewCustomStage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by bsalomon

Modified:
12 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make table color filter use asNewCustomStage. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5976

Patch Set 1 #

Total comments: 5

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -184 lines)			Patch
M	gyp/gpu.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/core/SkColorFilter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkColorFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	4 chunks	+167 lines, -7 lines	3 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	2 chunks	+1 line, -9 lines	2 comments	Download
D	src/gpu/effects/GrColorTableEffect.h	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	src/gpu/effects/GrColorTableEffect.cpp	View	1 chunk	+0 lines, -122 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6713051/diff/1/src/effects/SkTableColorFilter.cpp File src/effects/SkTableColorFilter.cpp (right): https://codereview.appspot.com/6713051/diff/1/src/effects/SkTableColorFilter.cpp#newcode219 src/effects/SkTableColorFilter.cpp:219: #include "GrCustomStage.h" Everything here up to GrCustomStage* SkTable_ColorFilter::asNewCustomStage() is ...

12 years, 3 months ago (2012-10-17 14:30:01 UTC) #1

robertphillips

LGTM + 2 questions. Do we already have a GM for this? https://codereview.appspot.com/6713051/diff/1/src/effects/SkTableColorFilter.cpp File src/effects/SkTableColorFilter.cpp ...

12 years, 3 months ago (2012-10-17 14:40:02 UTC) #2

bsalomon

12 years, 3 months ago (2012-10-17 14:54:37 UTC) #3

Yes, there is a tablecolorfilter.cpp.

https://codereview.appspot.com/6713051/diff/1/src/effects/SkTableColorFilter.cpp
File src/effects/SkTableColorFilter.cpp (right):

https://codereview.appspot.com/6713051/diff/1/src/effects/SkTableColorFilter....
src/effects/SkTableColorFilter.cpp:290: } else {
On 2012/10/17 14:40:02, robertphillips wrote:
> /0 issue here too?

Yup, I added the same trick (max with small value). Maybe this should be
captured somewhere in an unpremul function.

https://codereview.appspot.com/6713051/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.appspot.com/6713051/diff/1/src/gpu/SkGpuDevice.cpp#newcode517
src/gpu/SkGpuDevice.cpp:517: SkXfermode::Mode filterMode;
On 2012/10/17 14:40:02, robertphillips wrote:
> rm colorTransformTable too?

Done.

Expand All Messages | Collapse All Messages