Issue 6709070: Add support for GLSL 1.40.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6709070: Add support for GLSL 1.40. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bsalomon

Modified:
12 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add support for GLSL 1.40. Committed: https://code.google.com/p/skia/source/detail?r=6046

Patch Set 2 : #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
M	src/gpu/gl/GrGLSL.h	View		5 chunks	+10 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLSL.cpp	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6709070/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp File src/gpu/gl/GrGLShaderBuilder.cpp (left): https://codereview.appspot.com/6709070/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp#oldcode291 src/gpu/gl/GrGLShaderBuilder.cpp:291: fFSHeader.printf("#extension GL_ARB_fragment_coord_conventions: enable\n"); unrelated to the rest of the ...

12 years ago (2012-10-22 20:03:18 UTC) #1

LGTM

Expand All Messages | Collapse All Messages