Issue 6709069: Make Debugger print out more information (mainly w.r.t. SkBitmap)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6709069: Make Debugger print out more information (mainly w.r.t. SkBitmap) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by robertphillips

Modified:
12 years, 2 months ago

Reviewers:
DerekS, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Make Debugger print out more SkBitmap information

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -6 lines)			Patch
	M	debugger/SkObjectParser.cpp	View	1	4 chunks	+47 lines, -6 lines	0 comments	Download

Total messages: 4

reed1

mBitmap is a string? How about str? (total nit) SkString::appendS32(bitmap.width()) seems more obvious than calling ...

12 years, 2 months ago (2012-10-22 20:06:04 UTC) #2

DerekS

lgtm, but I agree with mike's nit of using s32 instead of doing the conversion.

12 years, 2 months ago (2012-10-22 20:27:26 UTC) #3

robertphillips

12 years, 2 months ago (2012-10-23 12:15:01 UTC) #4

Replaced 'appendScalar(SkIntToScalar())' with 'appendS32()'

committed as r6042