Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(992)

Issue 6709051: Altered arcTo's canonical points to (usually) be convex (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by robertphillips
Modified:
12 years, 1 month ago
Reviewers:
TomH, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

BEFORE arbroundrect 8888: cmsecs = 48.52 565: cmsecs = 46.33 GPU: cmsecs = 125.11 gmsecs = 121.22 NULLGPU: cmsecs = 58.97 gmsecs = 0.12 AFTER arbroundrect 8888: cmsecs = 41.03 565: cmsecs = 38.53 GPU: cmsecs = 47.11 gmsecs = 45.97 NULLGPU: cmsecs = 33.85 gmsecs = 0.11

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added Unit test & improved comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -20 lines) Patch
M bench/PathBench.cpp View 1 3 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 1 chunk +36 lines, -17 lines 0 comments Download
M tests/PathTest.cpp View 1 2 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 8
robertphillips
12 years, 1 month ago (2012-10-17 17:47:25 UTC) #1
TomH
Driveby LGTM
12 years, 1 month ago (2012-10-17 17:50:17 UTC) #2
bsalomon
LGTM https://codereview.appspot.com/6709051/diff/1/bench/PathBench.cpp File bench/PathBench.cpp (right): https://codereview.appspot.com/6709051/diff/1/bench/PathBench.cpp#newcode744 bench/PathBench.cpp:744: continue; --i?
12 years, 1 month ago (2012-10-17 19:26:26 UTC) #3
reed1
Sure, but... More dox in the code 1. why its broken 2. why this works-around-that ...
12 years, 1 month ago (2012-10-17 19:38:22 UTC) #4
robertphillips
PTAL Note: this CL will alter the baselines for: degeneratesegments shadertext shadertext2
12 years, 1 month ago (2012-10-18 13:54:46 UTC) #5
reed1
lgtm
12 years, 1 month ago (2012-10-18 15:16:43 UTC) #6
robertphillips
committed as r5997
12 years, 1 month ago (2012-10-18 15:26:25 UTC) #7
robertphillips
12 years, 1 month ago (2012-10-19 12:43:53 UTC) #8
This breaks the following 21 Webkit tests

    clip-path-restore.html
    background-leakage-transforms.html
    background-leakage.html
    border-radius-split-background.html
    border-radius-circle.html
    border-shadow-large-radius.html
    border-styles-split.html
    border-radius-big.html
    box-shadow-clipped-slices.html
    shadow-tiling-artifact.html
    spread-multiple-inset.html
    spread-multiple-normal.html
    spread.html
    box-shadow-and-border-radius.html
    shadow-multiple.html
    shadow-multiple-vertical.html
    shadows.html
    border-styles-vertical-lr.html
    border-styles-vertical-rl.html
    border-radius-style-005.htm
    stroke-width-large.svg
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b