Issue 67047: Remove disallowed/unrecognized css attributes rather than stop cajoling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67047: Remove disallowed/unrecognized css attributes rather than stop cajoling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by Jasvir

Modified:
16 years, 8 months ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Reduced the severity of unrecognized css attribute values from FATAL to WARNING Changed the tests to check for warnings The change was required to allow us to cajole ACID2 test (http://www.webstandards.org/files/acid2/test.html). @3494

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove disallowed/unrecognized css attributes rather than stop cajoling #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -44 lines)			Patch
	M	src/com/google/caja/plugin/PluginMessageType.java	View	1	3 chunks	+2 lines, -20 lines	0 comments	Download
	M	tests/com/google/caja/plugin/CssValidatorTest.java	View	1	16 chunks	+234 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSamuel

Please explain in the CL description why this change is necessary. http://codereview.appspot.com/67047/diff/1/2 File tests/com/google/caja/plugin/CssValidatorTest.java (right): ...

16 years, 11 months ago (2009-05-14 18:41:03 UTC) #2

MikeSamuel

16 years, 11 months ago (2009-05-14 22:25:54 UTC) #4

On 2009/05/14 22:17:31, jasvir wrote:
> snapshot with indentation and description corrected

LGTM

Expand All Messages | Collapse All Messages