Issue 6702043: Do not git ignore files like /debugger/QT/moc_*.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6702043: Do not git ignore files like /debugger/QT/moc_*. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Leon

Modified:
11 years, 7 months ago

Reviewers:
tfarina1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Do not git ignore files like /debugger/QT/moc_*. Prior to r5953, gyp_skia would generate files for QT in debugger/QT. A line in .gitignore was added so these files did not show up in git status. Now that the generated files are in the out directory, the line is no longer necessary. Committed: https://code.google.com/p/skia/source/detail?r=5966

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	.gitignore	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

tfarina1

11 years, 7 months ago (2012-10-15 18:47:43 UTC) #2

This works for me after https://codereview.appspot.com/6674044/.

LGTM. thanks.

Expand All Messages | Collapse All Messages