Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(369)

Issue 6702043: Do not git ignore files like /debugger/QT/moc_*. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Leon
Modified:
12 years, 2 months ago
Reviewers:
tfarina1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Do not git ignore files like /debugger/QT/moc_*. Prior to r5953, gyp_skia would generate files for QT in debugger/QT. A line in .gitignore was added so these files did not show up in git status. Now that the generated files are in the out directory, the line is no longer necessary. Committed: https://code.google.com/p/skia/source/detail?r=5966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
Leon
12 years, 2 months ago (2012-10-15 18:44:22 UTC) #1
tfarina1
12 years, 2 months ago (2012-10-15 18:47:43 UTC) #2
This works for me after https://codereview.appspot.com/6674044/.

LGTM. thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b