Require matrix for custom stage to be set when custom stage is installed.

Require matrix for custom stage to be set when custom stage is installed.
Committed: https://code.google.com/p/skia/source/detail?r=5962

[bsalomon, 2012-10-15 19:18:04]

In the near future GrCustomStages manage their own texture matrix. This means
the matrix needs be known when the GrCustomStage is created (since they are
immutable). 

This CL takes a step towards the future by requiring the texture matrix to be
passed to GrSamplerStage::setCustomStage().

It introduces a few ugly bits that will be removed once GrSamplerState no longer
owns the texture matrix. I noted them in the code comments.

It's probably easiest to read this by starting with GrSamplerState.h and then
SkShader.h. The rest of the changes are fallout from those modifications and are
pretty straightforward.

https://codereview.appspot.com/6696044/diff/3001/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.appspot.com/6696044/diff/3001/src/gpu/GrDrawState.cpp#newc...
src/gpu/GrDrawState.cpp:80: fSamplerMatrices[s] =
drawState->sampler(s)->getMatrix();
I missed this on an earlier CL.

[robertphillips, 2012-10-15 19:40:32]

LGTM + 2 potential refactorings

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkRadi...
File src/effects/gradients/SkRadialGradient.cpp (right):

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkRadi...
src/effects/gradients/SkRadialGradient.cpp:564: 
Could this following block be method? It seems like it also appears in
SkLinearGradient and SkSweepGradient.

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkTwoP...
File src/effects/gradients/SkTwoPointRadialGradient.cpp (right):

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkTwoP...
src/effects/gradients/SkTwoPointRadialGradient.cpp:655: SkScalar diffLen =
fDiff.length();
Is there anything to share here with SkTwoPointConicalGradient?

[bsalomon, 2012-10-16 14:15:50]

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkRadi...
File src/effects/gradients/SkRadialGradient.cpp (right):

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkRadi...
src/effects/gradients/SkRadialGradient.cpp:564: 
On 2012/10/15 19:40:32, robertphillips wrote:
> Could this following block be method? It seems like it also appears in
> SkLinearGradient and SkSweepGradient.

I thought about doing that but I also want to refactor how SkShader manage's its
local matrix anyway. So I think I'll hold off on it.

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkTwoP...
File src/effects/gradients/SkTwoPointRadialGradient.cpp (right):

https://codereview.appspot.com/6696044/diff/3001/src/effects/gradients/SkTwoP...
src/effects/gradients/SkTwoPointRadialGradient.cpp:655: SkScalar diffLen =
fDiff.length();
On 2012/10/15 19:40:32, robertphillips wrote:
> Is there anything to share here with SkTwoPointConicalGradient?

It's slightly different... and SkTwoPointRadialGradient is on its way out now
that WK is using the conical version.