Issue 66890043: Issue 1625:Add Feedback/Eval Preview and Join Confirmation UIs to mashup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66890043: Issue 1625:Add Feedback/Eval Preview and Join Confirmation UIs to mashup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by arnold.koroa

Modified:
10 years, 6 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Issue 1625:Add Feedback/Eval Preview and Join Confirmation UIs to mashup

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
	M	src/main/webapp/dev/mashup.jsp	View		9 chunks	+25 lines, -0 lines	0 comments	Download
	M	src/test/resources/data/MashupPageUiTest.json	View		4 chunks	+19 lines, -1 line	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

arnold.koroa

10 years, 7 months ago (2014-02-21 08:14:59 UTC) #1

https://codereview.appspot.com/66890043/diff/1/src/test/resources/data/Mashup...
File src/test/resources/data/MashupPageUiTest.json (right):

https://codereview.appspot.com/66890043/diff/1/src/test/resources/data/Mashup...
src/test/resources/data/MashupPageUiTest.json:514: "endTime":"2012-04-01 11:59
PM UTC",
null breaks student home page (even though this session is not supposed to
appear in the student home page in the first place).

Expand All Messages | Collapse All Messages