Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3973)

Issue 6683057: Add codereview.settings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by fujiwara
Modified:
11 years, 6 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git://github.com/ibus/ibus-anthy.git@master
Visibility:
Public.

Description

Add codereview.settings. This is for us to use codereview.appspot.com for code reviews. Instructions to use codereview.appspot.com: 1. Get depot_tools and add PATH to the directory http://dev.chromium.org/developers/how-tos/depottools 2. In your local IBus git repository, % git checkout master % git checkout -b somefix make changes % git cl upload do code reviews at codereview.appspot.com once it's done, run "git cl push" if you can commit. otherwise, ask committers to commit on behalf. Review URL: http://codereview.appspot.com/2166043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A codereview.settings View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
fujiwara
11 years, 6 months ago (2012-10-15 10:32:46 UTC) #1
Peng
11 years, 6 months ago (2012-10-15 13:30:03 UTC) #2
On 2012/10/15 10:32:46, fujiwara wrote:

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b