Issue 6683044: Add SK_API to base classes of classes with SK_API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6683044: Add SK_API to base classes of classes with SK_API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bungeman

Modified:
13 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Add SK_API to base classes of classes with SK_API.

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	include/core/SkDrawFilter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkMaskFilter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkRasterizer.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

bungeman

With https://code.google.com/p/skia/source/detail?r=5914 many effects were made SK_API, but the base classes here were not. As ...

13 years ago (2012-10-13 17:10:08 UTC) #1

bungeman

13 years ago (2012-10-13 17:15:21 UTC) #2

Patch Set 1 Committed revision 5946.

Keeping open for review in case alternate means can/should be found.