Issue 66810043: Issue 1629:Instructor cannot submit feedback if it's a private session

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66810043: Issue 1629:Instructor cannot submit feedback if it's a private session (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by arnold.koroa

Modified:
10 years, 6 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Issue 1629:Instructor cannot submit feedback if it's a private session

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+861 lines, -31 lines)			Patch
M	src/main/java/teammates/ui/controller/FeedbackSubmissionEditPageAction.java	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/FeedbackSubmissionEditPageData.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackPreviewAsInstructorAction.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackPreviewAsStudentAction.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackSubmissionEditPageAction.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackSubmissionEditSaveAction.java	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/StudentFeedbackSubmissionEditPageAction.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/StudentFeedbackSubmissionEditSaveAction.java	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/main/webapp/jsp/feedbackSubmissionEdit.jsp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackSubmissionEdit.jsp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/main/webapp/jsp/studentFeedbackSubmissionEdit.jsp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackSubmitPageUiTest.java	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/StudentFeedbackSubmitPageUiTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/test/resources/data/InstructorFeedbackSubmitPageUiTest.json	View	3 chunks	+82 lines, -2 lines	0 comments	Download
M	src/test/resources/data/MashupPageUiTest.json	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/test/resources/data/StudentFeedbackSubmitPageUiTest.json	View	3 chunks	+42 lines, -2 lines	0 comments	Download
A	src/test/resources/pages/instructorFeedbackSubmitPageAwaiting.html	View	1 chunk	+326 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackSubmitPageClosed.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	src/test/resources/pages/instructorFeedbackSubmitPagePrivate.html	View	1 chunk	+226 lines, -0 lines	0 comments	Download
A	src/test/resources/pages/studentFeedbackSubmitPageAwaiting.html	View	1 chunk	+145 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/studentFeedbackSubmitPageClosed.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download