Issue 66560045: Add a convenience factory that builds GoogleJsonResponseException instances for testing.

Issue 66560045: Add a convenience factory that builds GoogleJsonResponseException instances for testing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by wonderfly

Modified:
11 years, 10 months ago

Reviewers:
ngmiceli, yanivi

CC:
apatti

Base URL:
https://code.google.com/p/google-api-java-client/

Visibility:
Public.

More Reviews

Description

Add a convenience factory that builds GoogleJsonResponseException instances for testing. Also migrate ComputeCredential to point to the "v1" endpoint.

Patch Set 2 : Add a convenience factory that builds GoogleJsonResponseException instances for testing. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -8 lines)			Patch
M	google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
A	google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/package-info.java	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/compute/ComputeCredentialTest.java	View		2 chunks	+18 lines, -7 lines	0 comments	Download
A	google-api-client/src/test/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTestingTest.java	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

yanivi

Please fix the truncated description. https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java File google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java (right): https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java#newcode29 google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java:29: * {@link Beta} Missing ...

11 years, 10 months ago (2014-02-21 18:41:45 UTC) #2

wonderfly

https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java File google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java (right): https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java#newcode29 google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java:29: * {@link Beta} On 2014/02/21 18:41:45, yanivi wrote: > ...

11 years, 10 months ago (2014-02-21 19:48:17 UTC) #3

LGTM

Expand All Messages | Collapse All Messages