Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(505)

Issue 66560045: Add a convenience factory that builds GoogleJsonResponseException instances for testing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by wonderfly
Modified:
11 years, 10 months ago
Reviewers:
ngmiceli, yanivi
CC:
apatti
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

Add a convenience factory that builds GoogleJsonResponseException instances for testing. Also migrate ComputeCredential to point to the "v1" endpoint.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add a convenience factory that builds GoogleJsonResponseException instances for testing. #

Messages

Total messages: 4
wonderfly
11 years, 10 months ago (2014-02-21 01:42:58 UTC) #1
yanivi
Please fix the truncated description. https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java File google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java (right): https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java#newcode29 google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java:29: * {@link Beta} Missing ...
11 years, 10 months ago (2014-02-21 18:41:45 UTC) #2
wonderfly
https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java File google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java (right): https://codereview.appspot.com/66560045/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java#newcode29 google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/GoogleJsonResponseExceptionFactoryTesting.java:29: * {@link Beta} On 2014/02/21 18:41:45, yanivi wrote: > ...
11 years, 10 months ago (2014-02-21 19:48:17 UTC) #3
yanivi
11 years, 10 months ago (2014-02-21 19:54:24 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b