Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2013)

Issue 6654051: Avoid deadlock in SkGetFallbackFamilyNameForChar(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Xianzhu
Modified:
12 years, 1 month ago
Reviewers:
DerekS, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Avoid deadlock in SkGetFallbackFamilyNameForChar(). The deaklock happened when SkFontHost::CreateTypefaceFromStream() is called indirectly from SkGetFallbackFamilyNameForChar().

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M src/ports/SkFontHost_android.cpp View 5 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Xianzhu
12 years, 1 month ago (2012-10-12 00:12:27 UTC) #1
DerekS
lgtm
12 years, 1 month ago (2012-10-12 12:55:05 UTC) #2
DerekS
On 2012/10/12 12:55:05, DerekS wrote: > lgtm This code really needs an overhaul, but I'm ...
12 years, 1 month ago (2012-10-12 12:55:51 UTC) #3
Xianzhu
On 2012/10/12 12:55:51, DerekS wrote: > This code really needs an overhaul, but I'm holding ...
12 years, 1 month ago (2012-10-12 16:26:24 UTC) #4
DerekS
On 2012/10/12 16:26:24, wangxianzhu1 wrote: > On 2012/10/12 12:55:51, DerekS wrote: > > This code ...
12 years, 1 month ago (2012-10-15 16:04:27 UTC) #5
Xianzhu
12 years, 1 month ago (2012-10-15 16:48:03 UTC) #6
On 2012/10/15 16:04:27, DerekS wrote:
> You can go ahead and close out this issue.

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b