Issue 6654051: Avoid deadlock in SkGetFallbackFamilyNameForChar().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6654051: Avoid deadlock in SkGetFallbackFamilyNameForChar(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Xianzhu

Modified:
12 years, 2 months ago

Reviewers:
DerekS, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Avoid deadlock in SkGetFallbackFamilyNameForChar(). The deaklock happened when SkFontHost::CreateTypefaceFromStream() is called indirectly from SkGetFallbackFamilyNameForChar().

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	src/ports/SkFontHost_android.cpp	View		5 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

DerekS

On 2012/10/12 12:55:05, DerekS wrote: > lgtm This code really needs an overhaul, but I'm ...

12 years, 2 months ago (2012-10-12 12:55:51 UTC) #3

Xianzhu

On 2012/10/12 12:55:51, DerekS wrote: > This code really needs an overhaul, but I'm holding ...

12 years, 2 months ago (2012-10-12 16:26:24 UTC) #4

DerekS

On 2012/10/12 16:26:24, wangxianzhu1 wrote: > On 2012/10/12 12:55:51, DerekS wrote: > > This code ...

12 years, 2 months ago (2012-10-15 16:04:27 UTC) #5

Xianzhu

12 years, 2 months ago (2012-10-15 16:48:03 UTC) #6

On 2012/10/15 16:04:27, DerekS wrote:
> You can go ahead and close out this issue.

Thanks!

Expand All Messages | Collapse All Messages