Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(769)

Issue 6654050: code review 6654050: crypto/tls: make closeNotify a warning alert. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by agl1
Modified:
7 years, 7 months ago
Reviewers:
CC:
golang-dev, shanemhansen, rsc
Visibility:
Public.

Description

crypto/tls: make closeNotify a warning alert. The RFC doesn't actually have an opinion on whether this is a fatal or warning level alert, but common practice suggests that it should be a warning. This involves rebasing most of the tests. Fixes issue 3413.

Patch Set 1 #

Patch Set 2 : diff -r 18dffd0c07b2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 18dffd0c07b2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 18dffd0c07b2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6665bbc48b3b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -1017 lines) Patch
M src/pkg/crypto/tls/conn.go View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/pkg/crypto/tls/handshake_client_test.go View 1 2 3 chunks +50 lines, -50 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 1 9 chunks +701 lines, -965 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 7 months ago (2012-10-11 22:20:29 UTC) #1
shanemhansen
Not a committer, but LGTM. The RFC doesn't specify that you have to use a ...
7 years, 7 months ago (2012-10-12 03:11:02 UTC) #2
rsc
LGTM
7 years, 7 months ago (2012-10-16 17:18:38 UTC) #3
agl1
7 years, 7 months ago (2012-10-16 19:40:45 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=e64d4ee19fff ***

crypto/tls: make closeNotify a warning alert.

The RFC doesn't actually have an opinion on whether this is a fatal or
warning level alert, but common practice suggests that it should be a
warning.

This involves rebasing most of the tests.

Fixes issue 3413.

R=golang-dev, shanemhansen, rsc
CC=golang-dev
http://codereview.appspot.com/6654050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b