Issue 6652046: Change FreeType lcd filter to provide better results.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6652046: Change FreeType lcd filter to provide better results. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bungeman

Modified:
12 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Change FreeType lcd filter to provide better results.

Patch Set 2 : Address comments. #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View	1	4 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bungeman

With this change we can change we can change Chrome's skia.gyp to 'SK_GAMMA_EXPONENT=1.8', 'SK_GAMMA_CONTRAST=0.3', 'SK_CAN_USE_DLOPEN=1', ...

12 years, 2 months ago (2012-10-11 17:21:02 UTC) #1

reed1

https://codereview.appspot.com/6652046/diff/1/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.appspot.com/6652046/diff/1/src/ports/SkFontHost_FreeType.cpp#newcode99 src/ports/SkFontHost_FreeType.cpp:99: /* If you ever want to call SetLcdFilterWeights, you ...

12 years, 2 months ago (2012-10-11 17:39:24 UTC) #2

reed1

can we have a new OPT_IN flag present, so that CrOS can try this out ...

12 years, 2 months ago (2012-10-11 17:42:20 UTC) #3

bungeman

Added SK_FONTHOST_FREETYPE_USE_NORMAL_LCD_FILTER as an opt-in flag. https://codereview.appspot.com/6652046/diff/1/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): https://codereview.appspot.com/6652046/diff/1/src/ports/SkFontHost_FreeType.cpp#newcode99 src/ports/SkFontHost_FreeType.cpp:99: On 2012/10/11 17:39:24, ...

12 years, 2 months ago (2012-10-11 18:54:25 UTC) #4

Committed revision 5944.
Rebaselined revision 5945.

Expand All Messages | Collapse All Messages