Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1163)

Unified Diff: make.py

Issue 6651064: gyp: generate "everything" and "most" targets instead of "all" (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: synced_to_r6115 Created 12 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/everything.gyp ('k') | skia.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: make.py
===================================================================
--- make.py (revision 6115)
+++ make.py (working copy)
@@ -24,7 +24,6 @@
TARGET_CLEAN = 'clean'
TARGET_DEFAULT = 'most'
TARGET_GYP = 'gyp'
-LIST_OF_ALL_TARGETS = ['SampleApp', 'bench', 'gm', 'tests', 'tools']
SCRIPT_DIR = os.path.abspath(os.path.dirname(__file__))
OUT_SUBDIR = 'out'
@@ -141,8 +140,11 @@
targets = []
for arg in args:
+ # If user requests "make all", chain to our explicitly-declared "everything"
+ # target. See https://code.google.com/p/skia/issues/detail?id=932 ("gyp
+ # automatically creates "all" target on some build flavors but not others")
if arg == TARGET_ALL:
- targets.extend(LIST_OF_ALL_TARGETS)
+ targets.append('everything')
elif arg == TARGET_CLEAN:
MakeClean()
elif arg.startswith('BUILDTYPE='):
« no previous file with comments | « gyp/everything.gyp ('k') | skia.gyp » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b