Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1576)

Issue 6651051: Fix ANGLE build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by EricB
Modified:
11 years, 8 months ago
Reviewers:
epoger, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix ANGLE build Removed this in r5889. Committed: https://code.google.com/p/skia/source/detail?r=5904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M gyp/views.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
EricB
11 years, 8 months ago (2012-10-11 18:45:22 UTC) #1
bsalomon
On 2012/10/11 18:45:22, EricB wrote: Here is an alterna-fix which doesn't require making views depend ...
11 years, 8 months ago (2012-10-11 18:54:08 UTC) #2
epoger
On 2012/10/11 18:54:08, bsalomon wrote: > On 2012/10/11 18:45:22, EricB wrote: > > Here is ...
11 years, 8 months ago (2012-10-11 18:59:50 UTC) #3
bsalomon
On 2012/10/11 18:59:50, epoger wrote: > On 2012/10/11 18:54:08, bsalomon wrote: > > On 2012/10/11 ...
11 years, 8 months ago (2012-10-11 19:08:12 UTC) #4
bsalomon
lgtm
11 years, 8 months ago (2012-10-11 19:10:30 UTC) #5
bsalomon
11 years, 8 months ago (2012-10-11 19:29:25 UTC) #6
Ok, I get why the existing code worked. The GrGLInterface doesn't actually use
glFoo(). Instead it uses LoadLibrary()/GetProcAddress() to get a pointer to
ANGLE's implementation of glFoo().

So Eric's change is definitely better than mine. My change was making native GL
calls in place of ANGLE calls. I just didn't notice any visual errors when
running SampleApp.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b