Issue 665041: code review 665041: fix selected warnings from cppcheck

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 665041: code review 665041: fix selected warnings from cppcheck (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by rsc

Modified:
15 years, 1 month ago

Reviewers:

CC:
r, re2-dev_googlegroups.com

Visibility:
Public.

Description

fix selected warnings from cppcheck Fixes issue 2.

Patch Set 1 #

Patch Set 2 : code review 665041: fix selected warnings from cppcheck #

Patch Set 3 : code review 665041: fix selected warnings from cppcheck #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -29 lines)			Patch
M	re2/compile.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	re2/dfa.cc	View	1	4 chunks	+3 lines, -6 lines	0 comments	Download
M	re2/nfa.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	re2/prefilter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	re2/re2.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	re2/testing/backtrack.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	re2/testing/string_generator.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	re2/testing/tester.cc	View		1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-03-20 01:04:40 UTC) #1

LGTM On Mar 19, 2010, at 6:04 PM, rsc@golang.org wrote: > Reviewers: r, > > ...

15 years, 1 month ago (2010-03-20 01:40:52 UTC) #2

rsc

15 years, 1 month ago (2010-03-20 04:56:09 UTC) #3

*** Submitted as http://code.google.com/p/re2/source/detail?r=e74c398329ec ***

fix selected warnings from cppcheck

Fixes issue 2.

R=r
CC=re2-dev
http://codereview.appspot.com/665041

Expand All Messages | Collapse All Messages