Issue 6650047: SkTLazyReplace

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6650047: SkTLazyReplace (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

SkTCopyOnFirstWrite R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=5905

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -83 lines)			Patch
M	include/core/SkTLazy.h	View	1 2 3 4	1 chunk	+54 lines, -0 lines	0 comments	Download
M	src/core/SkBlitter.cpp	View	1 2	4 chunks	+8 lines, -23 lines	0 comments	Download
M	src/core/SkDraw.cpp	View	1 2	2 chunks	+5 lines, -9 lines	0 comments	Download
M	src/device/xps/SkXPSDevice.cpp	View	1 2	7 chunks	+24 lines, -35 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2	3 chunks	+7 lines, -15 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

way cooler! It seems we *always* have a ref at the call site, but pass ...

11 years, 8 months ago (2012-10-11 17:48:28 UTC) #3

bsalomon

11 years, 8 months ago (2012-10-11 17:52:52 UTC) #4

On 2012/10/11 17:48:28, reed1 wrote:
> way cooler!
> 
> It seems we *always* have a ref at the call site, but pass a ptr to the
> constructor. Do we support a null ptr? If not, can we change the constructor
to
> take a const& ?

Yeah, that makes sense, will do.

> 
> Other than that question, LGTM

Expand All Messages | Collapse All Messages