way cooler! It seems we *always* have a ref at the call site, but pass ...
12 years, 2 months ago
(2012-10-11 17:48:28 UTC)
#3
way cooler!
It seems we *always* have a ref at the call site, but pass a ptr to the
constructor. Do we support a null ptr? If not, can we change the constructor to
take a const& ?
Other than that question, LGTM
On 2012/10/11 17:48:28, reed1 wrote: > way cooler! > > It seems we *always* have ...
12 years, 2 months ago
(2012-10-11 17:52:52 UTC)
#4
On 2012/10/11 17:48:28, reed1 wrote:
> way cooler!
>
> It seems we *always* have a ref at the call site, but pass a ptr to the
> constructor. Do we support a null ptr? If not, can we change the constructor
to
> take a const& ?
Yeah, that makes sense, will do.
>
> Other than that question, LGTM
Issue 6650047: SkTLazyReplace
(Closed)
Created 12 years, 2 months ago by bsalomon
Modified 12 years, 2 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0