Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(824)

Issue 6649048: code review 6649048: crypto/rsa: fix decryption benchmark. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by agl1
Modified:
12 years, 5 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

crypto/rsa: fix decryption benchmark. I was an idiot and was thinking that a small base didn't matter because the exponentiation would quickly make the number the same size as the modulus. But, of course, the small base continues to make multiplications unrealistically cheap throughout the computation.

Patch Set 1 #

Patch Set 2 : diff -r caf30a0fbd77 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r caf30a0fbd77 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 57736947de5a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/crypto/rsa/rsa_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 5 months ago (2012-10-11 19:24:44 UTC) #1
r
LGTM
12 years, 5 months ago (2012-10-11 20:50:08 UTC) #2
agl1
12 years, 5 months ago (2012-10-11 22:27:15 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=2aa2c1c93060 ***

crypto/rsa: fix decryption benchmark.

I was an idiot and was thinking that a small base didn't matter
because the exponentiation would quickly make the number the same size
as the modulus. But, of course, the small base continues to make
multiplications unrealistically cheap throughout the computation.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6649048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b