Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3492)

Issue 6649043: Fix fallback 'C' locale in ibus-setup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by fujiwara
Modified:
11 years, 5 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Fix fallback 'C' locale in ibus-setup. BUG=RH#863673 TEST=Manually

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Updated with message #4. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M setup/main.py View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
fujiwara
11 years, 5 months ago (2012-10-11 07:51:24 UTC) #1
Peng
lgtm with a comment https://codereview.appspot.com/6649043/diff/1/setup/main.py File setup/main.py (right): https://codereview.appspot.com/6649043/diff/1/setup/main.py#newcode554 setup/main.py:554: print >> sys.stderr, "IBUS-WARNING **: ...
11 years, 5 months ago (2012-10-11 13:29:39 UTC) #2
fujiwara
On 2012/10/11 13:29:39, Peng wrote: > lgtm with a comment > > https://codereview.appspot.com/6649043/diff/1/setup/main.py > File ...
11 years, 5 months ago (2012-10-12 06:37:33 UTC) #3
Peng
On 2012/10/12 06:37:33, fujiwara wrote: > On 2012/10/11 13:29:39, Peng wrote: > > lgtm with ...
11 years, 5 months ago (2012-10-12 15:37:34 UTC) #4
fujiwara
11 years, 5 months ago (2012-10-15 02:45:12 UTC) #5
On 2012/10/12 15:37:34, Peng wrote:
> On 2012/10/12 06:37:33, fujiwara wrote:
> > On 2012/10/11 13:29:39, Peng wrote:
> > > lgtm with a comment
> > > 
> > > https://codereview.appspot.com/6649043/diff/1/setup/main.py
> > > File setup/main.py (right):
> > > 
> > > https://codereview.appspot.com/6649043/diff/1/setup/main.py#newcode554
> > > setup/main.py:554: print >> sys.stderr, "IBUS-WARNING **: Using the
fallback
> > 'C'
> > > locale"
> > > Can we use g_warning in python?
> > 
> > Updated the patch.
> > I think argv functions are not available in gir and probably logging could
> > provide the similar messages.
> 
> If it is impossible to call g_log in python, then we may just use print. And I
> think it is not necessary to add some string like "IBUS-WARNING **:";

OK, committed the original patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b