Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1986)

Issue 6643060: Fonts with cubic outlines are rendered without ClearType by GDI. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by bungeman
Modified:
11 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Different approach. #

Patch Set 3 : Split out FromFile into other CL. #

Patch Set 4 : Paint's typeface may be null. #

Patch Set 5 : Update all FontHosts. #

Total comments: 4

Patch Set 6 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -20 lines) Patch
M include/core/SkFontHost.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M include/core/SkTypeface.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_mac_atsui.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_mac_coretext.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_none.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 3 4 chunks +36 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/utils/ios/SkFontHost_iOS.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
bungeman
11 years, 8 months ago (2012-10-10 20:49:38 UTC) #1
reed1
1. lets land the createfromfile change on its own 2. can we keep kDevice or ...
11 years, 8 months ago (2012-10-11 17:14:10 UTC) #2
bungeman
All the other FontHost::FilterRec will need to be updated as well. 1. createfromfile split out ...
11 years, 8 months ago (2012-10-11 18:32:11 UTC) #3
bungeman
All existing issues should now be addressed.
11 years, 8 months ago (2012-10-11 20:00:31 UTC) #4
reed1
lgtm w/ minor comments (dox, Capitalization) https://codereview.appspot.com/6643060/diff/10001/include/core/SkFontHost.h File include/core/SkFontHost.h (right): https://codereview.appspot.com/6643060/diff/10001/include/core/SkFontHost.h#newcode169 include/core/SkFontHost.h:169: A lazy (but ...
11 years, 8 months ago (2012-10-12 16:21:31 UTC) #5
bungeman
11 years, 8 months ago (2012-10-12 18:49:08 UTC) #6
Committed revision 5929.

https://codereview.appspot.com/6643060/diff/10001/include/core/SkFontHost.h
File include/core/SkFontHost.h (right):

https://codereview.appspot.com/6643060/diff/10001/include/core/SkFontHost.h#n...
include/core/SkFontHost.h:169: A lazy (but valid) fonthost can do nothing in its
FilterRec routine.
On 2012/10/12 16:21:31, reed1 wrote:
> // The provided typeface corresponds to the fFontID field.

Done.

https://codereview.appspot.com/6643060/diff/10001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.appspot.com/6643060/diff/10001/include/core/SkTypeface.h#n...
include/core/SkTypeface.h:192: friend class SkScalerContext;
On 2012/10/12 16:21:31, reed1 wrote:
> Static Methods Begin With Capitals

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b