Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 6643050: code review 6643050: cmd/5l: generate FreeBSD compatible ELF (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by minux1
Modified:
12 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cmd/5l: generate FreeBSD compatible ELF 1. correctly initialize .plt.got entries (point to the 1st entry) 2. add section .rel.plt (FreeBSD insists PLT relocs to be there) 3. put relocs of .got.plt into .rel.plt 4. set ELFOSABI_FREEBSD in ELF header

Patch Set 1 #

Patch Set 2 : diff -r 2c2052f38c3c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 62b7ebe62958 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -23 lines) Patch
M src/cmd/5l/asm.c View 1 9 chunks +51 lines, -22 lines 0 comments Download
M src/cmd/5l/obj.c View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
minux1
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 5 months ago (2012-10-09 16:02:58 UTC) #1
minux1
I guess I always choose a bad time to propose CLs. ;-) I know we ...
12 years, 5 months ago (2012-10-09 16:17:53 UTC) #2
rsc
LGTM
12 years, 5 months ago (2012-10-09 16:41:05 UTC) #3
minux1
12 years, 5 months ago (2012-10-09 17:03:03 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=c58647359c01 ***

cmd/5l: generate FreeBSD compatible ELF
1. correctly initialize .plt.got entries (point to the 1st entry)
2. add section .rel.plt (FreeBSD insists PLT relocs to be there)
3. put relocs of .got.plt into .rel.plt
4. set ELFOSABI_FREEBSD in ELF header

R=rsc
CC=golang-dev
http://codereview.appspot.com/6643050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b