Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(649)

Issue 6642057: Make SkPictures valid regardless of SK_SUPPORT_HINTING_SCALE_FACTOR. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Leon
Modified:
11 years, 8 months ago
Reviewers:
DerekS, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make SkPictures valid regardless of SK_SUPPORT_HINTING_SCALE_FACTOR. When the build flag is not set, read/write dummy values so that the creator of an SKP file need not have the same support/lack of support of the feature as the reader. Will separately update the checked in skps to the new version when checking in. BUG=http://code.google.com/p/skia/issues/detail?id=922 Committed: https://code.google.com/p/skia/source/detail?r=5869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M src/core/SkPaint.cpp View 5 chunks +15 lines, -7 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Leon
11 years, 8 months ago (2012-10-09 19:44:40 UTC) #1
robertphillips
LGTM
11 years, 8 months ago (2012-10-09 19:46:41 UTC) #2
DerekS
11 years, 8 months ago (2012-10-09 19:58:30 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b