Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1674)

Issue 6640044: Remove external matrix feature. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by bsalomon
Modified:
11 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove external matrix feature. We haven't been testing this for nearly two years. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=5857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -99 lines) Patch
M include/core/SkCanvas.h View 2 chunks +0 lines, -5 lines 0 comments Download
M include/core/SkDraw.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/gpu/GrTextContext.h View 2 chunks +1 line, -4 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 6 chunks +1 line, -43 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 3 chunks +3 lines, -18 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
bsalomon
11 years, 8 months ago (2012-10-08 20:30:32 UTC) #1
reed1
11 years, 8 months ago (2012-10-08 20:40:26 UTC) #2
lgtm

    if (hasCustomD1GProc(*draw)) {
        // todo: fix this assumption about clips w/ custom
        fClip = draw->fClip;
        fClipBounds = fClip->getBounds();
        return draw->fProcs->fD1GProc;
    }

What the heck is that check?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b