Issue 6640043: HMAC verification does not use a cosntant time algorithm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6640043: HMAC verification does not use a cosntant time algorithm

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by ptoomey

Modified:
12 years, 9 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	oauth2client/xsrfutil.py	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jcgregorio_google

LGTM Committed at http://code.google.com/p/google-api-python-client/source/detail?r=4a7cfa4691a1b282f72c4ff488d8ae6508af8648

12 years, 9 months ago (2012-10-08 17:50:36 UTC) #1

ptoomey

12 years, 9 months ago (2012-10-08 17:54:31 UTC) #2

the associated bug:
http://code.google.com/p/google-api-python-client/issues/detail?id=204&sort=-id
can
be marked "fixed" when you have a chance.

Patrick

On Mon, Oct 8, 2012 at 10:50 AM, <jcgregorio@google.com> wrote:

> LGTM
>
> Committed at
> http://code.google.com/p/**google-api-python-client/**source/detail?r=**
>
4a7cfa4691a1b282f72c4ff488d8ae**6508af8648<http://code.google.com/p/google-api-python-client/source/detail?r=4a7cfa4691a1b282f72c4ff488d8ae6508af8648>
>
>
https://codereview.appspot.**com/6640043/<https://codereview.appspot.com/6640...
>

Expand All Messages | Collapse All Messages