code review 6639044: gofmt: apply gofmt -w -s src misc

gofmt: apply gofmt -w -s src misc

Preparation for forthcoming CL 6624051: Will make it
easier to see if/what changes are incurred by it.

The alignment changes in this CL are due to CL 6610051
(fix to alignment heuristic) where it appears that an
old version of gofmt was run (and thus the correct
alignment updates were not done).

[gri, 2012-10-09 22:52:40]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-10-09 23:39:07]

LGTM

http://codereview.appspot.com/6639044/diff/6001/src/cmd/cgo/gcc.go
File src/cmd/cgo/gcc.go (right):

http://codereview.appspot.com/6639044/diff/6001/src/cmd/cgo/gcc.go#newcode768
src/cmd/cgo/gcc.go:768: "-xc", // input language is C
why is this better?

[gri, 2012-10-10 00:00:47]

FYI.

https://codereview.appspot.com/6639044/diff/6001/src/cmd/cgo/gcc.go
File src/cmd/cgo/gcc.go (right):

https://codereview.appspot.com/6639044/diff/6001/src/cmd/cgo/gcc.go#newcode768
src/cmd/cgo/gcc.go:768: "-xc", // input language is C
On 2012/10/09 23:39:07, r wrote:
> why is this better?

In this specific case it may not be better, it's simply the result of the
heuristic that's been in place for a while (albeit until recently it wasn't
implemented symmetrically): When there is a list of lines where the ratio of the
lengths of successive line items (here the length of
"-fno-eliminate-unused-debug-types" vs "-c") is above a certain threshold and/or
a length maximum is exceeded, the previous block of aligned items is interrupted
and a new block of aligned items starts. In general (for very large tables),
that's a good thing because it prevents things such as comments to be very far
on the right just because of a single long entry on the left far away.

One could refine this of couse; for instance in this case the number of entries
is below a certain threshold (say 10, arbitrarily chosen), and thus perhaps in
this case a different approach should be used.

Leaving as is for now.

[gri, 2012-10-10 00:01:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=7a30d6a1d918 ***

gofmt: apply gofmt -w -s src misc

Preparation for forthcoming CL 6624051: Will make it
easier to see if/what changes are incurred by it.

The alignment changes in this CL are due to CL 6610051
(fix to alignment heuristic) where it appears that an
old version of gofmt was run (and thus the correct
alignment updates were not done).

R=r
CC=golang-dev
http://codereview.appspot.com/6639044