Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 6638053: code review 6638053: net/http: fix data race on countReader.n (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by dfc
Modified:
1 year, 6 months ago
Reviewers:
dvyukov
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

net/http: fix data race on countReader.n

Fixes issue 4220.

Patch Set 1 #

Patch Set 2 : diff -r c3570e8ed478 https://code.google.com/p/go #

Patch Set 3 : diff -r c3570e8ed478 https://code.google.com/p/go #

Patch Set 4 : diff -r cb38e940c38a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pkg/net/http/serve_test.go View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello dvyukov@google.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
1 year, 6 months ago #1
bradfitz
LGTM On Thu, Oct 11, 2012 at 2:50 PM, <dave@cheney.net> wrote: > Reviewers: dvyukov, bradfitz, ...
1 year, 6 months ago #2
dfc
*** Submitted as http://code.google.com/p/go/source/detail?r=57736947de5a *** net/http: fix data race on countReader.n Fixes issue 4220. R=dvyukov, ...
1 year, 6 months ago #3
dvyukov
1 year, 6 months ago #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5