Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(852)

Issue 6637047: code review 6637047: encoding/gob: fix data race in Register (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by r
Modified:
9 years, 3 months ago
Reviewers:
CC:
golang-dev, dsymonds, bradfitz
Visibility:
Public.

Description

encoding/gob: fix data race in Register Fixes issue 4214.

Patch Set 1 #

Patch Set 2 : diff -r 3350c94fe6b7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5a8c4552dd85 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5a8c4552dd85 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/pkg/encoding/gob/decode.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/encoding/gob/encode.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/encoding/gob/type.go View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/pkg/encoding/gob/type_test.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 3 months ago (2012-10-09 00:24:57 UTC) #1
dsymonds
This seems like an obvious use case for sync.RWMutex instead: an initial few writes, but ...
9 years, 3 months ago (2012-10-09 00:26:54 UTC) #2
bradfitz
RWMutex? On Mon, Oct 8, 2012 at 5:24 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
9 years, 3 months ago (2012-10-09 00:26:58 UTC) #3
r
Hello golang-dev@googlegroups.com, dsymonds@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 3 months ago (2012-10-09 00:43:13 UTC) #4
bradfitz
LGTM On Mon, Oct 8, 2012 at 5:43 PM, <r@golang.org> wrote: > Hello golang-dev@googlegroups.com, dsymonds@golang.org, ...
9 years, 3 months ago (2012-10-09 00:44:17 UTC) #5
dsymonds
LGTM
9 years, 3 months ago (2012-10-09 00:49:42 UTC) #6
r
9 years, 3 months ago (2012-10-09 00:56:53 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=ddfae026505a ***

encoding/gob: fix data race in Register
Fixes issue 4214.

R=golang-dev, dsymonds, bradfitz
CC=golang-dev
http://codereview.appspot.com/6637047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b