Issue 6636050: Remove gainFocus() and setMatrixClip() virtuals from SkDevice.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6636050: Remove gainFocus() and setMatrixClip() virtuals from SkDevice. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove gainFocus() and setMatrixClip() virtuals from SkDevice. R=reed@google.com,robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5861

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -128 lines)			Patch
M	include/core/SkCanvas.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	include/core/SkDevice.h	View		2 chunks	+0 lines, -23 lines	0 comments	Download
M	include/gpu/SkGpuDevice.h	View		4 chunks	+2 lines, -12 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View		5 chunks	+0 lines, -20 lines	0 comments	Download
M	src/core/SkDevice.cpp	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1	11 chunks	+23 lines, -62 lines	0 comments	Download
M	src/utils/SkDeferredCanvas.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages