code review 6635064: cmd/go: don't ignore error when 'go clean'

src/cmd/go/clean.go

 // Copyright 2012 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package main
 
 import (
         "fmt"
         "io/ioutil"
         "os"
@@ skipping 152 matching lines @@
                 name := dir.Name()
                 if dir.IsDir() {
                         // TODO: Remove once Makefiles are forgotten.
                         if cleanDir[name] {
                                 if cleanN || cleanX {
                                         b.showcmd(p.Dir, "rm -r %s", name)
                                         if cleanN {
                                                 continue
                                         }
                                 }
-                                f := filepath.Join(p.Dir, name)
-                                if err := os.RemoveAll(f); err != nil {
+                                if err := os.RemoveAll(filepath.Join(p.Dir, name)); err != nil {
                                         errorf("go clean: %v", err)
                                 }
                         }
                         continue
                 }
 
                 if cleanN {
                         continue
                 }
 
@@ skipping 32 matching lines @@
         }
 }
 
 // removeFile tries to remove file f, if error other than file doesn't exist
 // occurs, it will report the error.
 func removeFile(f string) {
         if err := os.Remove(f); err != nil && !os.IsNotExist(err) {
                 errorf("go clean: %v", err)
         }
 }