Issue 6633051: code review 6633051: bytes: fix tests and fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6633051: code review 6633051: bytes: fix tests and fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by adg

Modified:
12 years, 5 months ago

Reviewers:
gri

CC:
golang-dev, eds2

Visibility:
Public.

Description

bytes: fix tests and fix build

Patch Set 1 #

Patch Set 2 : diff -r f9f27066cb90 https://code.google.com/p/go #

Patch Set 3 : diff -r f9f27066cb90 https://code.google.com/p/go #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	src/pkg/bytes/buffer_test.go	View	1	7 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 5 months ago (2012-10-10 00:41:08 UTC) #1

eds2

I'm guessing bytes/reader_test.go needs this treatment too? - Evan

12 years, 5 months ago (2012-10-10 00:43:43 UTC) #2

adg

Actually no; just that file because buffer_test.go defined a bytes variable. I didn't need to ...

12 years, 5 months ago (2012-10-10 00:58:06 UTC) #3

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=bc37ede4a36d *** bytes: fix tests and fix build R=golang-dev, edsrzf CC=golang-dev http://codereview.appspot.com/6633051

12 years, 5 months ago (2012-10-10 00:59:46 UTC) #5

LGTM

Expand All Messages | Collapse All Messages