code review 6633050: bytes: make examples work in playground

bytes: make examples work in playground

[adg, 2012-10-10 00:09:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-10-10 00:10:12]

LGTM

On Tue, Oct 9, 2012 at 5:09 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> bytes: make examples work in playground
>
> Please review this at
http://codereview.appspot.com/**6633050/<http://codereview.appspot.com/6633050/>
>
> Affected files:
>   M src/pkg/bytes/example_test.go
>
>
> Index: src/pkg/bytes/example_test.go
> ==============================**==============================**=======
> --- a/src/pkg/bytes/example_test.**go
> +++ b/src/pkg/bytes/example_test.**go
> @@ -5,14 +5,14 @@
>  package bytes_test
>
>  import (
> -       . "bytes"
> +       "bytes"
>         "encoding/base64"
>         "io"
>         "os"
>  )
>
>  func ExampleBuffer() {
> -       var b Buffer // A Buffer needs no initialization.
> +       var b bytes.Buffer // A Buffer needs no initialization.
>         b.Write([]byte("Hello "))
>         b.Write([]byte("world!"))
>         b.WriteTo(os.Stdout)
> @@ -21,7 +21,7 @@
>
>  func ExampleBuffer_reader() {
>         // A Buffer can turn a string or a []byte into an io.Reader.
> -       buf := NewBufferString("**R29waGVycyBydWxlIQ==")
> +       buf := bytes.NewBufferString("**R29waGVycyBydWxlIQ==")
>         dec := base64.NewDecoder(base64.**StdEncoding, buf)
>         io.Copy(os.Stdout, dec)
>         // Output: Gophers rule!
>
>
>

[bradfitz, 2012-10-10 00:11:18]

https://codereview.appspot.com/6633050/diff/1/src/pkg/bytes/example_test.go
File src/pkg/bytes/example_test.go (right):

https://codereview.appspot.com/6633050/diff/1/src/pkg/bytes/example_test.go#n...
src/pkg/bytes/example_test.go:17: b.Write([]byte("world!"))
I might change this to:

fmt.Fprintf(&b, "World!")

to show that the pointer type is what implements io.Writer.

[adg, 2012-10-10 00:15:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=cac6af12528b ***

bytes: make examples work in playground

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6633050

http://codereview.appspot.com/6633050/diff/1/src/pkg/bytes/example_test.go
File src/pkg/bytes/example_test.go (right):

http://codereview.appspot.com/6633050/diff/1/src/pkg/bytes/example_test.go#ne...
src/pkg/bytes/example_test.go:17: b.Write([]byte("world!"))
On 2012/10/10 00:11:18, bradfitz wrote:
> I might change this to:
> 
> fmt.Fprintf(&b, "World!")
> 
> to show that the pointer type is what implements io.Writer.
> 

Good idea. Done.