Use XKB layout string instead of ibus-keyboard icon on panel.

Use XKB layout string instead of ibus-keyboard icon on panel.

[Peng, 2014-02-20 15:22:18]

https://codereview.appspot.com/66330043/diff/1/data/ibus.schemas.in
File data/ibus.schemas.in (right):

https://codereview.appspot.com/66330043/diff/1/data/ibus.schemas.in#newcode266
data/ibus.schemas.in:266: <default>[0.255, 0.313, 0.6]</default>
Using an array for color? Is it a common usage in gnome? Could you please check
gnome project to make sure it is the right way?

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala#newcode401
ui/gtk3/panel.vala:401: m_xkb_icon_red =
variant.get_child_value(0).get_double();
maybe clamp it into [0,1.0]

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala#newcode702
ui/gtk3/panel.vala:702: var desc = Pango.FontDescription.from_string("Monospace
Bold 22");
How did you choice the front size? And it is better to define "Monospace Bold
22" and "Monospace Bold 18" as a const value in class.

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala#newcode717
ui/gtk3/panel.vala:717: private Gdk.Pixbuf create_icon_pixbuf_with_string(string
symbol) {
Should we consider cache the result of this function? In case the in an ibus
session, it only has few xkb layouts, and just need switche between them
frequently.

[fujiwara, 2014-02-21 09:53:51]

https://codereview.appspot.com/66330043/diff/1/data/ibus.schemas.in
File data/ibus.schemas.in (right):

https://codereview.appspot.com/66330043/diff/1/data/ibus.schemas.in#newcode266
data/ibus.schemas.in:266: <default>[0.255, 0.313, 0.6]</default>
On 2014/02/20 15:22:18, Peng wrote:
> Using an array for color? Is it a common usage in gnome? Could you please
check
> gnome project to make sure it is the right way?

OK, I see.
Now I use PangoColor.

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala#newcode401
ui/gtk3/panel.vala:401: m_xkb_icon_red =
variant.get_child_value(0).get_double();
On 2014/02/20 15:22:18, Peng wrote:
> maybe clamp it into [0,1.0]

The code was deleted.

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala#newcode702
ui/gtk3/panel.vala:702: var desc = Pango.FontDescription.from_string("Monospace
Bold 22");
On 2014/02/20 15:22:18, Peng wrote:
> How did you choice the front size? And it is better to define "Monospace Bold
> 22" and "Monospace Bold 18" as a const value in class.

Probably I think the size is fixed because the font is drawn on 48x48 icon
campus.
But I'm not sure if it's the best size.

https://codereview.appspot.com/66330043/diff/1/ui/gtk3/panel.vala#newcode717
ui/gtk3/panel.vala:717: private Gdk.Pixbuf create_icon_pixbuf_with_string(string
symbol) {
On 2014/02/20 15:22:18, Peng wrote:
> Should we consider cache the result of this function? In case the in an ibus
> session, it only has few xkb layouts, and just need switche between them
> frequently.

Done.

[Peng, 2014-02-24 17:20:09]

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala#newcode64
ui/gtk3/panel.vala:64: private Pango.Color m_xkb_icon_color;
Can we use Gdk.RGBA?

https://developer.gnome.org/gdk3/stable/gdk3-RGBA-Colors.html#GdkRGBA
http://valadoc.org/#!api=gdk-3.0/Gdk.RGBA?

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala#newcode393
ui/gtk3/panel.vala:393: }
Consider setting the color to the default color, parse(spec) failed.

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala#newcode705
ui/gtk3/panel.vala:705: cr.set_source_rgb(m_xkb_icon_color.red / 65535.0,
cr.set_source_rgba(Gdk.RGBA)?

[fujiwara, 2014-02-25 04:58:19]

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala#newcode64
ui/gtk3/panel.vala:64: private Pango.Color m_xkb_icon_color;
On 2014/02/24 17:20:10, Peng wrote:
> Can we use Gdk.RGBA?
> 
> https://developer.gnome.org/gdk3/stable/gdk3-RGBA-Colors.html#GdkRGBA
> http://valadoc.org/#!api=gdk-3.0/Gdk.RGBA?

Done.

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala#newcode393
ui/gtk3/panel.vala:393: }
On 2014/02/24 17:20:10, Peng wrote:
> Consider setting the color to the default color, parse(spec) failed.

Done.

https://codereview.appspot.com/66330043/diff/20001/ui/gtk3/panel.vala#newcode705
ui/gtk3/panel.vala:705: cr.set_source_rgb(m_xkb_icon_color.red / 65535.0,
On 2014/02/24 17:20:10, Peng wrote:
> cr.set_source_rgba(Gdk.RGBA)?

Done.

[Peng, 2014-02-25 05:08:02]

lgtm