Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 6624059: code review 6624059: io/ioutil: fix data race under the race detector (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by dvyukov
Modified:
4 years, 7 months ago
Reviewers:
CC:
rsc, minux1, golang-dev
Visibility:
Public.

Description

io/ioutil: fix data race under the race detector See issue 3970 (it's already marked as Fixed).

Patch Set 1 #

Patch Set 2 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r a1bbd399fc9b https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
A src/pkg/io/ioutil/blackhole.go View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A src/pkg/io/ioutil/blackhole_race.go View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/pkg/io/ioutil/ioutil.go View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
4 years, 7 months ago (2012-10-07 14:37:44 UTC) #1
minux1
do you want to mention Issue 3970?
4 years, 7 months ago (2012-10-07 14:44:21 UTC) #2
dvyukov
On 2012/10/07 14:44:21, minux wrote: > do you want to mention Issue 3970? thanks. done
4 years, 7 months ago (2012-10-07 14:51:36 UTC) #3
rsc
LGTM
4 years, 7 months ago (2012-10-07 15:20:56 UTC) #4
dvyukov
4 years, 7 months ago (2012-10-07 18:08:10 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=1e55cf10aa4f ***

io/ioutil: fix data race under the race detector
See issue 3970 (it's already marked as Fixed).

R=rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6624059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted