Issue 6624052: GrPaint encapsulation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6624052: GrPaint encapsulation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

GrPaint encapsulation. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5838

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -94 lines)			Patch
M	gm/texdata.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	include/gpu/GrPaint.h	View	1 2	8 chunks	+129 lines, -36 lines	1 comment	Download
M	src/effects/SkBlendImageFilter.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		8 chunks	+15 lines, -32 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

This is a long overdue change that makes GrPaint a "real" class and adds more ...

11 years, 8 months ago (2012-10-05 18:45:17 UTC) #1

robertphillips

11 years, 8 months ago (2012-10-05 19:01:11 UTC) #2

LGTM + 1 typo

https://codereview.appspot.com/6624052/diff/4001/include/gpu/GrPaint.h
File include/gpu/GrPaint.h (right):

https://codereview.appspot.com/6624052/diff/4001/include/gpu/GrPaint.h#newcod...
include/gpu/GrPaint.h:191: /**
If the If the -> If the

Expand All Messages | Collapse All Messages